Upgrade github/codeql dependency to 2.18.4#810
Merged
knewbury01 merged 22 commits intomainfrom Dec 6, 2024
Merged
Conversation
…bsolute path' problem has been fixed.
Use `semmle.code.cpp.dataflow.DataFlow` instead of a coding standards specific copy
Fix expected warning format in tests
C++: Accept test changes from #16969
A12-8-6: Update tests around unused template special members.
github-actions
bot
force-pushed
the
codeql/upgrade-to-2.18.4
branch
from
aa98b0a to
466f16e
Compare
We had some new false positives because in 2.18.4 string taint is tracked into the qualifier of a string operation, such as insert. This caused us to erroneously identify the container itself as a reference to an element of the container. This has been addressed by excluding uses of the owning container from pointer or reference access.
Contributor
|
/test-performance |
Author
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
- Rule 1.5 has an extra data flow node that is harmless. - The other rules had changes to the .ql which affected the location of the deprecated data flow library warnings.
Contributor
|
@MichaelRFairhurst This upgrade accepts some changes to the |
knewbury01
reviewed
Dec 5, 2024
Collaborator
knewbury01
left a comment
knewbury01
left a comment
There was a problem hiding this comment.
I mean I think this is fine, other than wanting to understand why we are changing our approach of handling the dataflow lib deprecation warnings
c/cert/src/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the CodeQL CLI version to 2.18.4.
CodeQL dependency upgrade checklist:
github/codeqltest cases succeed.github/codeql-coding-standardsrepository.